So you have read through the contributor's guide and you're getting ready to send your first pull request. Perhaps you've found an issue in React Native and want to work with the maintainers to land a fix. Here's what you can expect to happen when you open an issue or send a pull request.
The following is adapted from the excellent Open Source Guide from GitHub and reflects how the maintainers of React Native are encouraged to handle your contributions.
We see dozens of new issues being created every day. In order to help maintainers focus on what is actionable, maintainers ask contributors to do a bit of work prior to opening a new issue:
- New issues should follow the Issue Template.
- Issues should provide clear, easy to follow steps alongside sample code to reproduce the issue. Ideally, provide a Snack.
Issues that do not meet the above criteria can be closed immediately, with a link to the contributor's guide.
New issue runbook
You have gathered all the information required to open a new issue, and you are confident it meets the contributor guidelines. Once you post an issue, this is what our maintainers will consider when deciding how to move forward:
Is this issue a feature request?
Some features may not be a good fit for the core React Native library. This is usually the case for *new modules that Facebook does not use in production. In this case, a maintainer will explain that this should be released to npm as a separate module, allowing users to easily pull in the module in their projects.
Even if the feature does belong in the core library, adding it means maintaining it. A maintainer will encourage you to submit a pull request or otherwise post your request to Canny.
An exception can be made for proposals and long-running discussions, though these should be rare. If you have been contributing to the project long enough, you will probably already have access to the React Native Core Contributors Facebook Group, where this sort of discussion is usually held.
Is this issue a request for help?
Questions should absolutely be asked on Stack Overflow rather than GitHub. Maintainers should encourage contributors to ask on Stack Overflow, before closing the issue. Feel free to also answer some questions on Stack Overflow, you'll get rep!
Was the Issue Template used to fill out the issue? Did the author answer Yes to both questions at the top?
If not, the maintainer will ask you to provide more information by filling out the issue template, then they will close the issue.
Is the issue a duplicate of an existing, open issue?
A maintainer will add a comment,
Duplicate of #123, which will mark the issue as a duplicate of issue #123. They will then close the issue.
Does the issue include a Snack or list of steps to reproduce the issue?
Issues should be relatively easy to reproduce. Sometimes the issue affects a particular app but a minimal repro is not provided, perhaps a crash is seen in the logs and the author is not sure where its coming from, maybe the issue is sporadic.
As it happens, if a maintainer cannot easily reproduce the issue, one cannot reasonably expect them to be able to work on a fix. The maintainer will let you know this is the case, and your issue will be closed.
Exceptions can be made if multiple people appear to be affected by the issue, especially right after a new React Native release is cut.
Is the issue for an old release of React Native?
If so, expect to be asked if the issue can be reproduced in the latest release candidate.
Can the issue be reliably reproduced?
Transient issues or issues that only occur on a specific project but a minimum repro is not provided may be closed.
Does the issue need more information?
Some issues need additional information in order to reproduce them. Maintainers should explain what additional information is needed, after adding the 'Needs more information' label.
Issues with the 'Needs more information' label that have been open for more than a week without a response from the author can be closed.
Has the issue been resolved already in the comments?
Sometimes another contributor has already provided a solution in the comments. Maintainers may close the issue in this case.
Reopening a closed issue: Sometimes it's necessary to reopen an issue. For example, if an issue was closed waiting for the author, then the author replied and it turns out this is indeed a bug, maintainers can reopen the issue.
Valid bug reports with good repro steps are some of the best issues! Maintainers should thank the author for finding the issue, then explain that React Native is a community project and ask them if they would be up for sending a fix.
If a issue is still open after going through all of the checks above, it will move on to the triage stage. A maintainer will then do the following:
- Add relevant labels.
- Leave a comment saying the issue has been triaged.
- Tag the relevant people.
You can generally figure out who may be relevant for a given issue by looking at the CODEOWNERS file.
Issues in the "Needs more information" state may be closed after a week with no followup from the author. Issues that have had no activity in the last two months may be closed periodically. If your issue gets closed in this manner, it's nothing personal. If you strongly believe that the issue should remain open, just let us know why.
Simply commenting that the issue still exists is not very compelling (it's rare for critical, release blocking issues to have no activity for two months!). In order to make a good case for reopening the issue, you may need to do a bit of work:
- Can the issue be reproduced on the latest release candidate? Post a comment with the version you tested.
- If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
- Is there a pull request that addressed this issue? Post a comment with the PR number so we can follow up.
A couple of contributors making a good case may be all that is needed to reopen the issue.
Handling pull requests
The core team will be monitoring for pull requests. When we get one, we'll run some Facebook-specific integration tests on it first. From here, we'll need to get another person to sign off on the changes and then merge the pull request. For API changes we may need to fix internal uses, which could cause some delay. We'll do our best to provide updates and feedback throughout the process.
How we prioritize pull requests
We use the Contributors Chrome extension to help us understand who is sending a pull request. Pull requests opened by contributors that have a history of having their PRs merged are more likely to be looked at first. Aside from that, we try to go through pull requests on a chronological order.
How we review pull requests
Reviewing a PR can sometimes require more time from a maintainer than it took you to write the code. Maintainers need to consider all the ramifications of importing your patch into the codebase. Does it potentially introduce breaking changes? What are the performance considerations of adding a new dependency? Will the docs need to be updated as well? Does this belong in core, or would it be a better fit as a third party package?
Once you open a pull request, this is how you can expect maintainers to review it:
Is the pull request missing information?
A test plan is required! Add the labels 'Needs revision' and 'Needs response from author'. You can then follow up with a response like:
Hey @author, thanks for sending the pull request. Can you please add all the info specified in the template? This is necessary for people to be able to understand and review your pull request.
Does the code style match the Style guide?
If not, link to the style guide and add the label 'Needs revision'.
Does the pull request add a completely new feature we don't want to add to the core and maintain?
Ask the author to release it a separate npm module and close the pull request.
Does the pull request do several unrelated things at the same time?
Ask the author to split it.
Is the pull request old and need rebasing?
Ask the author "Can you rebase please?" and add the label 'Needs response from author'.
Is a pull request waiting for a response from author?
Pull requests like these usually have the label 'Needs response from author'. If there has been no reply in the last 30 days, close it with a response like the following:
Thanks for making the pull request, but we are closing it due to inactivity. If you want to get your proposed changes merged, please rebase your branch with master and send a new pull request.
Is the pull request old and waiting for review?
Closing pull requests
Sometimes a maintainer may decide that a pull request will not be accepted. Maybe the pull request is out of scope for the project, or the idea is good but the implementation is poor. Whatever the reason, when closing a pull request maintainers should keep the conversation friendly:
- Thank them for their contribution.
- Explain why it doesn't fit into the scope of the project.
- Link to relevant documentation, if you have it.
- Close the request.
Sometimes when a maintainer says no to a pull request or close an issue, a contributor may get upset and criticize your decision. Maintainers will take steps to defuse the situation.
If a contributor becomes hostile or disrespectful, they will be referred to the Code of Conduct. Negative users will be blocked, and inappropriate comments will be deleted.
Facebook GitHub Bot
The Facebook GitHub Bot was used to allow members of the community to perform administrative actions such as labeling and closing issues. The bot is no longer necessary, as maintainers will be granted the necessary permissions to manage issues. If you are interested in maintaining the repo, please reach out to Héctor Ramos (@hramos) on GitHub.